Julia decided to review her previous practices, and then she rewrote the C# code to prepare code review on stackexchange.com. The question was reviewed in less than 8 hours.
The review is conducted by the C# expert.
Actionable Items:
1. Julia did not know C# StringBuilder.Length property can be used to modify the length of string. Read the document about the comparison with string.Length. Through code review, Julia learned the lesson.
Please go over all the properties and function of StringBuilder.
2. The review's highlights:
Julia put together the C# code with code review's advice.
1. Declare a class PhoneKeyboard
2. Declare a public static readonly variable:
private static readonly string[] keyboard = new string[] { "", "", "abc", "def", "ghi", "jkl", "mno", "pqrs", "tuv", "wxyz" };
3. Function name FindAllWordsForNumber
public static IEnumerable<string> FindAllWordsForNumber(string digits)
Coding is like a sport, you have to give yourself
chance to play against top players. Thanks for
the code review to show me the great strength
from one of top players.
- jianmin chen Feb. 11, 2017
No comments:
Post a Comment